FreeCAD: master 4e58747c

Author Committer Branch Timestamp Parent
chennes wmayer master 2021-03-15 00:12:51 master 07804a8c
Affected Issues  0004353: parameters of rotate_extrude in CSG files and openscad workbench are ignored
Changeset [OpenSCAD] Add $fn and angle to rotate_extrude()

As pointed out in Issue 0004353 the OpenSCAD Workbench does not
correctly implement the angle parameter to rotate_extrude (it's a
relatively recent addition to OpenSCAD), nor does it attempt to do
anything with a specified $fn. This commit adds both features. To add
$fn handling, the code from the cylinder extrusion was mimicked,
allowing FreeCAD to create perfect, smooth representations when $fn
exceeds a user specified value in Preferences, but attempting to create
OpenSCAD's more discrete representation when using a lower $fn. Note
that this determination is made at creation time: if the user later
increases the segments parameter in the new object, it will remain
prismatic regardless of how high the value is made.
mod - src/Mod/OpenSCAD/OpenSCADFeatures.py Diff File
mod - src/Mod/OpenSCAD/OpenSCADTest/app/test_importCSG.py Diff File
mod - src/Mod/OpenSCAD/importCSG.py Diff File