All Projects FreeCAD  Addon Manager  Arch  Assembly  Draft  Expressions  FEM  File formats  GCS  OpenSCAD  Part  PartDesign  Path  Project Tools & Websites  Raytracing  Robot  Sketcher  Spreadsheet  TechDraw

FreeCAD: master fb64a860

Diff Back to Repository
Author Committer Branch Timestamp Parent
howetuft wmayer master 2019-11-16 09:41:05 master 4b5ca311
Changeset Fix -Wredundant-move warnings, 2nd try

std::move is redundant when it is used to return a local object from a function (eg return std::move(local)): indeed, returning a local object from a function implicitly moves it. Moreover using std::move this way
See https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rf-return-move-local
However, in order to avoid -Wreturn-std-move as well, a Base object is move-constructed
from Derived when required.
mod - src/Mod/Part/App/FaceMakerCheese.cpp Diff File
mod - src/Mod/Part/App/TopoShape.cpp Diff File
mod - src/Mod/Part/Gui/DlgProjectionOnSurface.cpp Diff File
mod - src/Mod/Path/App/Area.cpp Diff File
mod - src/Mod/Sketcher/App/ExternalGeometryExtension.cpp Diff File
mod - src/Mod/Sketcher/App/SketchGeometryExtension.cpp Diff File