All Projects FreeCAD  Addon Manager  Arch  Assembly  Draft  Expressions  FEM  File formats  GCS  OpenSCAD  Part  PartDesign  Path  Project Tools & Websites  Raytracing  Robot  Sketcher  Spreadsheet  TechDraw

FreeCAD: master 11d4d6c1

Diff Back to Repository
Author Committer Branch Timestamp Parent
abdullah abdullahtahiriyo master 2020-12-04 13:52:59 master 4e199bd2
Changeset Part/Sketcher: GeometryExtension/GeometryPersistentExtension split

==================================================================

GeometryExtension was originally designed to be serializable (save/restore). However,
GeometryMigrationExtension and ViewProviderSketchGeometryExtension have demonstrated the
usefulness of runtime-only GeometryExtensions.

The problem with runtime-only extensions being of a serializable type (GeometryExtension before
this commit) arises when Part::Geometry is to serialize the extensions and serialise the number
of extensions the geometry has. If runtime-only GeometryExtensions do not save a tag, then the
restore mechanism will expect more extensions that are actually in the XML file.

This commit makes GeometryExtension by default not serializable and deriving directly from
Base::BaseClass. A new class GeometryPersistentExtension is created, deriving from GeometryExtension
to provide serialisation. All Extensions requiring serialization derive from GeometryPersistentExtension
and those not requiring it from GeometryExtension directly.

This commit adapts all extensions to the new situation:
Part: GeometryDefaultExtension
Part: GeometryMigrationExtension
Sketcher: ViewProvierSketchGeometryExtension
Sketcher: SketchGeometryExtension and ExternalGeometryExtension
mod - src/Mod/Part/App/AppPart.cpp Diff File
mod - src/Mod/Part/App/Geometry.cpp Diff File
mod - src/Mod/Part/App/GeometryDefaultExtension.cpp Diff File
mod - src/Mod/Part/App/GeometryDefaultExtension.h Diff File
mod - src/Mod/Part/App/GeometryExtension.cpp Diff File
mod - src/Mod/Part/App/GeometryExtension.h Diff File
mod - src/Mod/Part/App/GeometryMigrationExtension.cpp Diff File
mod - src/Mod/Part/App/GeometryMigrationExtension.h Diff File
mod - src/Mod/Sketcher/App/ExternalGeometryExtension.cpp Diff File
mod - src/Mod/Sketcher/App/ExternalGeometryExtension.h Diff File
mod - src/Mod/Sketcher/App/SketchGeometryExtension.cpp Diff File
mod - src/Mod/Sketcher/App/SketchGeometryExtension.h Diff File
mod - src/Mod/Sketcher/Gui/ViewProviderSketchGeometryExtension.cpp Diff File
mod - src/Mod/Sketcher/Gui/ViewProviderSketchGeometryExtension.h Diff File