FreeCAD- Anonymous
| Author | Committer | Branch | Timestamp | Parent |
|---|---|---|---|---|
| abdullah | abdullahtahiriyo | master | 2020-12-24 10:54:18 | master 1d56289c |
| Changeset | Sketcher: Fix crash on constraint rename ======================================== Report: https://github.com/FreeCAD/FreeCAD/pull/4183 https://github.com/realthunder/FreeCAD_assembly3/issues/387 Problem: renameConstraint() previously implemented exclusively in SketchObjectPyImp.cpp, will change the Constraints property without updating the solver. A prospective drag operation would rely on a deleted pointer constraint which leads to the crash. Solution: - mark the solver status as needing an update - leverage new through sketchobject r/w interface to ensure solver is synchronised before the temporary move operation starts Bonus: move the core of the function to SketchObject.cpp so that input data validity check on constraint change is inhibited. |
|||
| mod - src/Mod/Sketcher/App/SketchObject.cpp | Diff File | |||
| mod - src/Mod/Sketcher/App/SketchObject.h | Diff File | |||
| mod - src/Mod/Sketcher/App/SketchObjectPyImp.cpp | Diff File | |||