FreeCAD: master 946e980d

Author Committer Branch Timestamp Parent
chennes wwmayer master 2021-02-08 15:42:37 master cbc3fbd1
Changeset LGTM: Move seq->next out of loop control

LGTM points out that the construct use in the loop here "does
nothing" -- that is, it is a conditional whose result is never used.
It is apparently being used simply to ensure that the next() function is
called on each loop iteration, but because sequence may be null, it is
shoehorned into a trinary :? operator. To clarify the intent and ensure
that later readers (including LGTM) do not misunderstand it,
this code is broken out into a more standard conditional construct at
the end of each loop iteration.
mod - src/App/Document.cpp Diff File