FreeCADFreeCAD: master 595fc118
| Author | Committer | Branch | Timestamp | Parent |
|---|---|---|---|---|
| abdullah | abdullahtahiriyo | master | 2021-01-14 06:15:37 | master f4e3e8ab |
| Changeset | Part: Part2DObject::seekTrimPoints rename parameters ==================================================== This function takes parameters named GeoId, which evoke the Sketcher GeoId and which indeed are used by the sketcher. However, these indices are just indices of the provided geometry list. Therefore: 1. The are never negative (no matter if a corresponding Sketcher GeoId is external or not). 2. They do not have reserved indices for axes. 3. Most importantly, not found GeoId1 and GeoId2 are coded as -1, which for the Sketcher has a well defined meaning (axis), whereas the Sketcher uses Constraint::GeoUndef as undefined or not present/ not found index, which currently is -2000. For these reasons, it was judged appropriate to rename the parameters and documentation to emphasise that this function is unrelated and dettached from any Sketcher knowledge, and that indices are just normal indices of a vector. |
|||
| mod - src/Mod/Part/App/Part2DObject.cpp | Diff File | |||
| mod - src/Mod/Part/App/Part2DObject.h | Diff File | |||
