All Projects FreeCAD  Addon Manager  Arch  Assembly  Draft  Expressions  FEM  File formats  GCS  OpenSCAD  Part  PartDesign  Path  Project Tools & Websites  Raytracing  Robot  Sketcher  Spreadsheet  TechDraw

FreeCAD: master a00769be

Diff Back to Repository
Author Committer Branch Timestamp Parent
Kunda1 yorik master 2019-12-17 03:56:04 master d49edcc9
Changeset LGTM: remove unnecessary 'pass' statements

Issue: A pass statement is only necessary when it is the only statement in a block (the list of statements forming part of a compound statement). This is because the purpose of the pass statement is to allow empty blocks where they would otherwise be syntactically invalid. If the block already contains other statements then the pass statement is unnecessary.

Recommendation: Remove the pass statement.

Relevant links:
https://lgtm.com/projects/g/FreeCAD/FreeCAD/snapshot/1a82a5e136d24ed9862c0fd7e41070049a23fa32/files/src/Mod/Import/stepZ.py?sort=name&dir=ASC&mode=heatmap#x78f479c31a062553:1

https://lgtm.com/projects/g/FreeCAD/FreeCAD/snapshot/1a82a5e136d24ed9862c0fd7e41070049a23fa32/files/src/Mod/OpenSCAD/OpenSCADCommands.py#xad4868ffcdf82498:1

https://lgtm.com/projects/g/FreeCAD/FreeCAD/snapshot/1a82a5e136d24ed9862c0fd7e41070049a23fa32/files/src/App/FreeCADInit.py#x9034ec6815c48e38:1
mod - src/App/FreeCADInit.py Diff File
mod - src/Mod/Import/stepZ.py Diff File
mod - src/Mod/OpenSCAD/OpenSCADCommands.py Diff File