Changesets: FreeCAD

master a4e38bae

2020-07-26 18:53:57

TheMarkster


Committer: yorik Details Diff
[CheckGeometry] add new shapecontent builder instead of OCCT's to correct some errors in OCCT's values and to add for some more advanced information, e.g. volume or area, add new method to Base::Interpreter runStringWithKey() -- allows to run a python script and get a string return value
mod - src/Base/Interpreter.cpp Diff File
mod - src/Base/Interpreter.h Diff File
mod - src/Mod/Part/Gui/TaskCheckGeometry.cpp Diff File
mod - src/Mod/Part/Gui/TaskCheckGeometry.h Diff File

master d7ee728b

2020-07-26 17:39:23

uwestoehr


Committer: wandererfan Details Diff
assure the translation

- also fix a typo
mod - src/Mod/TechDraw/Gui/ViewProviderPage.cpp Diff File
mod - src/Mod/TechDraw/Gui/ViewProviderProjGroup.cpp Diff File
mod - src/Mod/TechDraw/Gui/ViewProviderTemplate.cpp Diff File

master 48f90857

2020-07-26 17:30:24

wmayer

Details Diff
LGTM: [skip ci] fix: Local variable hides global variable
A local variable or parameter that hides a global variable of the same name.
This may be confusing. Consider renaming one of the variables.
mod - src/Gui/BitmapFactory.cpp Diff File
mod - src/Gui/SoFCDB.cpp Diff File
mod - src/Gui/ViewProviderPyImp.cpp Diff File
mod - src/Mod/Drawing/App/FeaturePage.cpp Diff File

master 5e6e03b6

2020-07-26 15:11:59

uwestoehr


Committer: wandererfan Details Diff
improve coding style
mod - src/Mod/TechDraw/Gui/ViewProviderPage.cpp Diff File
mod - src/Mod/TechDraw/Gui/ViewProviderProjGroup.cpp Diff File
mod - src/Mod/TechDraw/Gui/ViewProviderTemplate.cpp Diff File

master 2a8fe510

2020-07-26 15:07:41

uwestoehr


Committer: wwmayer Details Diff
[App/Gui] improve coding style

inspired by the changes made with https://github.com/FreeCAD/FreeCAD/commit/dc65b055e514
mod - src/App/DocumentPyImp.cpp Diff File
mod - src/Gui/DocumentPyImp.cpp Diff File

master 2b33e777

2020-07-26 14:53:44

uwestoehr


Committer: wandererfan Details Diff
[TD] get rid of trailing newlines

as discussed with luzpaz in https://github.com/FreeCAD/FreeCAD/pull/3735
there shouldn't be trailing newlines in translated strings.

- Moreover fix the logic of the output dialog text
mod - src/Mod/TechDraw/Gui/ViewProviderPage.cpp Diff File
mod - src/Mod/TechDraw/Gui/ViewProviderProjGroup.cpp Diff File
mod - src/Mod/TechDraw/Gui/ViewProviderTemplate.cpp Diff File

master 21becb4e

2020-07-26 14:44:44

wandererfan

Details Diff
[TD]remove obsolete QPointF (LGTM)
mod - src/Mod/TechDraw/Gui/QGIViewBalloon.cpp Diff File
mod - src/Mod/TechDraw/Gui/QGIViewBalloon.h Diff File

master cb90b6a1

2020-07-26 14:31:35

wandererfan

Details Diff
[TD]remove obsolete QGraphicRectItem (LGTM)
mod - src/Mod/TechDraw/Gui/QGIProjGroup.cpp Diff File
mod - src/Mod/TechDraw/Gui/QGIProjGroup.h Diff File

master 04f18423

2020-07-26 14:26:51

wandererfan

Details Diff
[TD]remove obsolete QGraphicsSVGItem (LGTM)
mod - src/Mod/TechDraw/Gui/QGIFace.cpp Diff File
mod - src/Mod/TechDraw/Gui/QGIFace.h Diff File

master dc65b055

2020-07-26 13:49:14

wmayer

Details Diff
LGTM: [skip ci] fix: Empty branch of conditional
An empty block after a conditional can be a sign of an omission and can decrease maintainability of the code.
Such blocks should contain an explanatory comment to aid future maintainers.
mod - src/App/DocumentPyImp.cpp Diff File
mod - src/Gui/DlgToolbarsImp.cpp Diff File
mod - src/Gui/NavigationStyle.cpp Diff File
mod - src/Gui/SoFCColorBar.cpp Diff File
mod - src/Gui/View3DInventorViewer.cpp Diff File
mod - src/Mod/Mesh/Gui/MeshEditor.cpp Diff File
mod - src/Mod/Part/Gui/ViewProviderExt.cpp Diff File
mod - src/Mod/PartDesign/App/FeatureSketchBased.cpp Diff File
mod - src/Mod/Raytracing/Gui/ViewProvider.cpp Diff File
mod - src/Mod/Sketcher/App/SketchObject.cpp Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherCreateCommands.cpp Diff File

master 8dc95874

2020-07-26 12:36:17

uwestoehr


Committer: wandererfan Details Diff
[TD] add 2 shortcuts for dimensions

as discussed here: https://forum.freecadweb.org/viewtopic.php?f=35&t=48980
mod - src/Mod/TechDraw/Gui/CommandCreateDims.cpp Diff File

master 4a5cca33

2020-07-26 12:29:45

realthunder


Committer: wwmayer Details Diff
PartDesign: fix pattern transformation
mod - src/Mod/PartDesign/App/FeatureTransformed.cpp Diff File

master f97d27cb

2020-07-26 09:28:52

SurajDadral


Committer: yorik Details Diff
Fix placement of rebar wires in Draft.getSVG.py
mod - src/Mod/Draft/getSVG.py Diff File

master 9dac347f

2020-07-26 00:24:18

wandererfan

Details Diff
[TD]fix Dim selection fails to clear prev selection
mod - src/Mod/TechDraw/Gui/MDIViewPage.cpp Diff File
mod - src/Mod/TechDraw/Gui/QGIViewDimension.cpp Diff File

master 102cfb4a

2020-07-25 22:11:23

paul lee


Committer: yorik Details Diff
[Draft - geotuils.offsets] Fix To Work with Sketch

Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=48852&p=419209#p419209
mod - src/Mod/Draft/draftgeoutils/offsets.py Diff File

master 7a410786

2020-07-25 21:25:00

paul lee


Committer: yorik Details Diff
[Draft - geoutils.offsets] Fix Circle and Arc Offset Direction

Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=48852#p418903
mod - src/Mod/Draft/draftgeoutils/offsets.py Diff File

master 47aeb41b

2020-07-25 18:54:48

uwestoehr


Committer: wwmayer Details Diff
[Win installer] add missing translations

the translation folder was missing

- also add safe guards that really only the desired subfolders will be part of the installer not also files that may exist in the base folder
mod - src/WindowsInstaller/setup/install.nsh Diff File

master a1f41871

2020-07-25 16:34:43

uwestoehr


Committer: wwmayer Details Diff
[Win installer] remove FindProc plugin

there is no need to have 2 plugins doing the same
moreover FindProc does no longer work with recent Windows 10 versions, so it must be removed anyway

- configure.nsh: small code optimization
- Settings.nsh: update year
mod - src/WindowsInstaller/Settings.nsh Diff File
mod - src/WindowsInstaller/include/init.nsh Diff File
mod - src/WindowsInstaller/setup/configure.nsh Diff File

master 584a1bf4

2020-07-25 12:48:59

wmayer

Details Diff
LGTM: [skip ci] fix: Resource not released in destructor
mod - src/Mod/Mesh/Gui/SoFCMeshObject.cpp Diff File
mod - src/Mod/Mesh/Gui/SoFCMeshObject.h Diff File
mod - src/Mod/Mesh/Gui/ViewProvider.cpp Diff File

master 71d64a7b

2020-07-25 11:35:16

luz paz


Committer: wmayer Details Diff
Crowdin: Fix superfluous newlines + uniformity [skip-ci]

https://crowdin.com/translate/freecad/27911/en-en#6578930
https://crowdin.com/translate/freecad/27911/en-en#6584458
https://crowdin.com/translate/freecad/27911/en-en#6584460

Note: Parts of the issue are handled with PR 3744
mod - src/Mod/TechDraw/Gui/CommandDecorate.cpp Diff File

master 598baecd

2020-07-25 03:36:59

vocx-fc


Committer: wwmayer Details Diff
Part: move Shape view properties to Part design preferences
mod - src/Mod/Part/Gui/AppPartGui.cpp Diff File
mod - src/Mod/Part/Gui/DlgSettingsObjectColor.ui Diff File

master 8dac7e46

2020-07-25 00:02:10

wandererfan

Details Diff
[TD]fix misaligned PAT hatch on section
mod - src/Mod/TechDraw/App/DrawGeomHatch.cpp Diff File
mod - src/Mod/TechDraw/App/DrawUtil.cpp Diff File
mod - src/Mod/TechDraw/App/DrawUtil.h Diff File

master d51955f6

2020-07-24 23:39:02

vocx-fc


Committer: yorik Details Diff
Draft: makeLayer, small adjustments to keep compatibility

This follows from the migration of the Layer code
done in 831e517717.

In the older `makeLayer` function, the parameters `drawstyle`
and `transparency` could be `None`; in the new `make_layer` function,
`drawstyle` must be an explicit string, and `transparency`
must be a number. If not provided, they use default values.
mod - src/Mod/Draft/draftmake/make_layer.py Diff File

master 16edad7a

2020-07-24 18:57:14

wmayer

Details Diff
LGTM: [skip ci] fix: Accidental rethrow
mod - src/Mod/Robot/Gui/ViewProviderRobotObject.cpp Diff File
mod - src/Mod/Surface/App/FeatureGeomFillSurface.cpp Diff File

master d300d148

2020-07-24 18:37:17

wmayer

Details Diff
LGTM: [skip ci] fix: Function declared in block
mod - src/Mod/TechDraw/App/EdgeWalker.cpp Diff File
 First  Prev  1 2 3 ... 70 ... 104 105 106 107 108 109 110 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 649 650 651  Next  Last