FreeCADChangesets: FreeCAD
|
master f018b1de 2021-03-01 05:11:52 Details Diff |
[DRAFT] Remove unused loop variable LGTM is concerned about the unused loop variable in this algorithm. While there was nothing wrong here, to eliminate the alarm the loop was removed entirely, since Python allows the use of the multiplication operator here to achieve the same effect. |
||
| mod - src/Mod/Draft/draftguitools/gui_trimex.py | Diff File | ||
|
master 011e1906 2021-03-01 04:26:00 grggnzlz Committer: abdullah Details Diff |
Sketcher: fix performance issue with drawing svg icons | ||
| mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp | Diff File | ||
|
master d78017f2 2021-03-01 03:48:31 Details Diff |
[Draft] Return once the button is found | ||
| mod - src/Mod/Draft/draftguitools/gui_snaps.py | Diff File | ||
|
master 58a6f059 2021-03-01 03:42:46 Details Diff |
[DRAFT] Refactor sync_snap_toolbar_button LGTM objected to the re-use of the loop variable a in the algorithm. Upon closer inspection, the algorithm in this function could be modified to match the algorithm in sync_snap_statusbar_button (which does the same thing to the statusbar that this does to the toolbar). This eliminates the double-use. This change does not affect the functionality of the routine. |
||
| mod - src/Mod/Draft/draftguitools/gui_snaps.py | Diff File | ||
|
master 6be90155 2021-03-01 02:27:23 Details Diff |
Add library versions to LibraryVersions.h | ||
| mod - LibraryVersions.h.cmake | Diff File | ||
| mod - src/Gui/Splashscreen.cpp | Diff File | ||
|
master f481c471 2021-03-01 01:20:18 Committer: wwmayer Details Diff |
[PD] fix multi-transform View - fixes bug 4581 See the first issue reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=56093#p482553 - also fix issue that one could set 1 occurrence for polar patterns despite 2 are required at least - also fix potential dereferencing null pointer (reported by MSVC) |
Affected Issues 0004581 |
|
| mod - src/Mod/PartDesign/Gui/TaskMultiTransformParameters.cpp | Diff File | ||
| mod - src/Mod/PartDesign/Gui/TaskPolarPatternParameters.cpp | Diff File | ||
|
master d1439107 2021-02-28 13:44:37 M G Berberich Committer: wwmayer Details Diff |
[PD] fixes problem with the path for user-defined hole-cut-types https://forum.freecadweb.org/viewtopic.php?f=19&t=51403&start=20#p482574 |
||
| mod - src/Mod/PartDesign/App/FeatureHole.cpp | Diff File | ||
|
master 3131b97a 2021-02-28 12:35:14 Committer: wmayer Details Diff |
PartDesign: Transformed. Fix regression in preview | ||
| mod - src/Mod/PartDesign/App/FeatureTransformed.cpp | Diff File | ||
| mod - src/Mod/PartDesign/App/FeatureTransformed.h | Diff File | ||
| mod - src/Mod/PartDesign/Gui/ViewProviderTransformed.cpp | Diff File | ||
|
master 957eed7d 2021-02-28 11:37:50 Details Diff |
Gui: [skip ci] allow to unbind() an ExpressionBinding and automatically unbind it if the observed object has been deleted For more details see: https://forum.freecadweb.org/viewtopic.php?f=8&t=56097 |
||
| mod - src/Gui/ExpressionBinding.cpp | Diff File | ||
| mod - src/Gui/ExpressionBinding.h | Diff File | ||
|
master 8453d415 2021-02-28 09:10:29 Committer: wmayer Details Diff |
PartDesign: Transformed. Fix regression for Mirrored, and multiple features | ||
| mod - src/Mod/PartDesign/App/FeatureTransformed.cpp | Diff File | ||
|
master bcb070de 2021-02-27 22:27:34 luz paz Committer: wwmayer Details Diff |
Crowdin: Startpage - add whitespace to tooltip [skip ci] |
Affected Issues 0004578 |
|
| mod - src/Mod/Start/Gui/DlgStartPreferences.ui | Diff File | ||
|
master 2ff669e5 2021-02-27 22:26:04 luz paz Committer: wwmayer Details Diff |
Crowdin: Startpage: remove obsolete translation [skip ci] |
Affected Issues 0004578 |
|
| mod - src/Mod/Start/Gui/Resources/translations/StartPage.ts | Diff File | ||
|
master e0b5aade 2021-02-27 22:19:43 luz paz Committer: wwmayer Details Diff |
Crowdin: StartPage - remove obsolete translation [skip ci] Ticket 0004578 ref: https://crowdin.com/translate/freecad/7254/en-en?filter=basic&value=0#6572932 |
Affected Issues 0004578 |
|
| mod - src/Mod/Start/Gui/Resources/translations/StartPage.ts | Diff File | ||
|
master 82354979 2021-02-27 17:17:52 Details Diff |
Gui: [skip ci] fix memory leak in SelectionFilter | ||
| mod - src/Gui/SelectionFilter.cpp | Diff File | ||
| mod - src/Gui/SelectionFilter.h | Diff File | ||
| mod - src/Gui/SelectionFilter.tab.c | Diff File | ||
| mod - src/Gui/SelectionFilter.y | Diff File | ||
|
master f5b6c206 2021-02-27 11:45:48 Details Diff |
Tools: updatecrowdin.py rewrite to support new api Crowdin has depreciated their old api and will shut it down completely in december 2021. What's new: * rewritten in Python 3 (drops support for discontinued Python 2) * uses Crowdin's api v2 * runs on vanilla Python 3, (no external modules) * automatically adds new translation from the src directory * supports api token to be specified in an environment variable (Makes GitHub integration easier in the future) * requires project id to be explicitly set with an environment variable (Makes testing safer) The api token can be set either in ~/.crowdin-freecad-token similar to how the old api key was set, or by specifying it in an environment variable. The later has been added to make it easier with GitHub-Crowdin integration in the future. The requirement to explicitly set CROWDIN_PROJECT_ID has been introduced to avoid accidentally using the main Crowdin project while testing the script. The script has been tested on Python versions 3.7, 3.8 and 3.9. Co-authored-by: Mattias Pierre <github@mattiaspierre.com> |
||
| mod - src/Tools/updatecrowdin.py | Diff File | ||
|
master 0e9b8ef4 2021-02-27 11:09:23 Gustav Skog Committer: wmayer Details Diff |
Reworked Prefereces Sketcher Colors User interface, adding groupings. | ||
| mod - src/Mod/Sketcher/Gui/SketcherSettingsColors.ui | Diff File | ||
|
master bd755b65 2021-02-27 10:13:30 Details Diff |
Gui: [skip ci] re-add removed Py_INCREF of module | ||
| mod - src/App/Application.cpp | Diff File | ||
|
master df0f979f 2021-02-27 09:56:19 Details Diff |
App/Gui: fix memory leaks: + add function to cleanup units and quantities in debug build + fix reference leak in PropertyVector::getPyPathValue() + fix reference leak in PropertyPlacement::getPyPathValue() + in InterpreterSingleton::init() use a static std::vector<wchar_t*> instead of a C array to free memory at program end + in MainWindow::closeEvent() explicitly delete all task watchers + in ReportOutputObserver constructor pass parent to QObject + in PropertyEditor destructor explicitly delete QItemEditorFactory |
||
| mod - src/App/Application.cpp | Diff File | ||
| mod - src/App/Application.h | Diff File | ||
| mod - src/App/PropertyGeo.cpp | Diff File | ||
| mod - src/Base/Interpreter.cpp | Diff File | ||
| mod - src/Gui/Application.cpp | Diff File | ||
| mod - src/Gui/MainWindow.cpp | Diff File | ||
| mod - src/Gui/ReportView.cpp | Diff File | ||
| mod - src/Gui/propertyeditor/PropertyEditor.cpp | Diff File | ||
|
master c7c420ca 2021-02-27 09:43:40 Committer: wwmayer Details Diff |
PartDesign: Hole. Address Donovaly bugs 7 and 8 bug 7: the update view checkbox should be enabled/disabled based on Model thread. the checked state should not change bug 8: the Thread depth options should be disabled when Model thread is unchecked. because they don't do anything in the model it is confusing if they are enabled. |
||
| mod - src/Mod/PartDesign/Gui/TaskHoleParameters.cpp | Diff File | ||
|
master 16ff933b 2021-02-27 08:27:23 Committer: wwmayer Details Diff |
PartDesign: Transformded. Align the "property category" of Refine with other PD commands | ||
| mod - src/Mod/PartDesign/App/FeatureTransformed.cpp | Diff File | ||
|
master 5d5d0561 2021-02-27 01:21:14 Details Diff |
App: [skip ci] AddressSanitizer: heap-use-after-free When removing a dynamic property its myName member must be nullified as the memory has been de-allocated |
||
| mod - src/App/DynamicProperty.cpp | Diff File | ||
|
master c1408f13 2021-02-27 00:55:55 Committer: wmayer Details Diff |
[OpenSCAD] Add unit test framework to module The OpenSCAD module did not have any unit tests. This commit adds the basic framework (and two very simple tests). The framework is modeled after the unit tests in the FEM module. |
||
| mod - src/Mod/OpenSCAD/CMakeLists.txt | Diff File | ||
| mod - src/Mod/OpenSCAD/Init.py | Diff File | ||
| mod - src/Mod/OpenSCAD/InitGui.py | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/__init__.py | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/app/__init__.py | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/app/test_importCSG.py | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/data/CSG.csg | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/data/CSG.scad | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/data/__init__.py | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/gui/__init__.py | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/gui/test_dummy.py | Diff File | ||
| add - src/Mod/OpenSCAD/OpenSCADTest/test_information.md | Diff File | ||
| add - src/Mod/OpenSCAD/TestOpenSCADApp.py | Diff File | ||
| add - src/Mod/OpenSCAD/TestOpenSCADGui.py | Diff File | ||
|
master b2ca86d8 2021-02-26 07:11:16 Details Diff |
FEM: [skip ci] fix crash in Constraint::getDirection | ||
| mod - src/Mod/Fem/App/FemConstraint.cpp | Diff File | ||
|
master e2bb84fd 2021-02-26 04:48:01 Committer: wwmayer Details Diff |
[Tools] Fix static analyis issues This commit addresses issues identified by LGTM for the various independent (and mostly-independent) files in the Tools subdirectory. The vast majority of the issues are trivial, and are things like unused imports or catching BaseException. There was one true bug identified, a global variable being changed in a function where it was not marked global, but it only affected output quantity (the variable is named "VERBOSE"). A couple of other issues identified variables that appear to represent no-longer-existing options in the code. The options were left, but a deprecation printout replaces the variable in the event the option is provided. |
||
| mod - src/Tools/ArchiveNameFromVersionHeader.py | Diff File | ||
| mod - src/Tools/DistTools.py | Diff File | ||
| mod - src/Tools/FCFileTools.py | Diff File | ||
| mod - src/Tools/LicenseChecker.py | Diff File | ||
| mod - src/Tools/MakeApp.py | Diff File | ||
| mod - src/Tools/MakeAppTools.py | Diff File | ||
| mod - src/Tools/MakeMacBundleRelocatable.py | Diff File | ||
| mod - src/Tools/MemoryLeaks.py | Diff File | ||
| mod - src/Tools/PythonToCPP.py | Diff File | ||
| mod - src/Tools/SubWCRev.py | Diff File | ||
| mod - src/Tools/WinVersion.py | Diff File | ||
| mod - src/Tools/catfiles.py | Diff File | ||
| mod - src/Tools/dir2qrc.py | Diff File | ||
| mod - src/Tools/doctools.py | Diff File | ||
| mod - src/Tools/fcbt.py | Diff File | ||
| mod - src/Tools/freecad-thumbnailer | Diff File | ||
| mod - src/Tools/generate.py | Diff File | ||
| mod - src/Tools/makedist.py | Diff File | ||
| mod - src/Tools/pythondoc.py | Diff File | ||
| mod - src/Tools/updatecrowdin.py | Diff File | ||
| mod - src/Tools/updateppa.py | Diff File | ||
| mod - src/Tools/wiki2qhelp.py | Diff File | ||
|
master 4b4a6b35 2021-02-26 02:57:14 Committer: wwmayer Details Diff |
[Offline Docs] Fix static analysis issues LGTM identified a number of minor issues (mostly unused imports) in the offline docs code. This commit addresses those, plus tweaks some output formatting to include missing spaces, makes a regex more rigorously safe by escaping some periods, and updates the use of a get() function which appears to have changed since it was first written. |
||
| mod - src/Tools/offlinedoc/buildpdf.py | Diff File | ||
| mod - src/Tools/offlinedoc/buildqhelp.py | Diff File | ||
| mod - src/Tools/offlinedoc/buildwikiindex.py | Diff File | ||
| mod - src/Tools/offlinedoc/downloadwiki.py | Diff File | ||
| mod - src/Tools/offlinedoc/update.py | Diff File | ||
