View Issue Details

IDProjectCategoryView StatusLast Update
0001505FreeCADPatchpublic2014-04-16 13:39
Reporternickoe Assigned Towmayer  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionreopened 
PlatformLinux 
Summary0001505: Fix multiple bugs in Idf.py
DescriptionWhen trying to fix the issue in
http://www.freecadweb.org/tracker/view.php?id=1366

It was improperly merged, I fix this in this patch. In addition to that I had to fix a path to make the script run succesfully.
Steps To ReproduceImport a IDF file and see that freecad complains in the terminal it was started.
TagsNo tags attached.
FreeCAD Information

Relationships

related to 0001424 closed emn import failure 

Activities

nickoe

2014-04-13 10:41

reporter  

0001-Fix-multiple-bugs-in-Idf.py.patch (Attachment missing)

nickoe

2014-04-13 10:49

reporter  

bm.emn (Attachment missing)

nickoe

2014-04-13 11:08

reporter  

example-idf.zip (Attachment missing)

wmayer

2014-04-13 11:51

administrator   ~0004552

Weird, I have never seen a merge failing so badly: https://github.com/FreeCAD/FreeCAD_sf_master/commit/e1b5f91378114eb993db7aff2c356503d067b9dd

nickoe

2014-04-13 12:06

reporter   ~0004553

Me neither, but none the less it happened. I wanted to test the reffered bug out, so I found that I also had to fix the path to footprints_models.csv.

nickoe

2014-04-13 12:25

reporter   ~0004554

I see you comitted it. But I see you did not change idflibs to Idflibs. Starting with a capital 'I'. That is what it is named on my system at least.

nickoe

2014-04-13 12:32

reporter   ~0004555

It has to be Idflibs, it is also specified as such in the Idf CMakeLists.txt

wmayer

2014-04-13 14:04

administrator   ~0004556

> It has to be Idflibs, it is also specified as such in the Idf CMakeLists.txt
Oops, sorry I have overlooked this. I thought it was only the moved slash.

Related Changesets

FreeCAD: master be8c5938

2014-04-13 13:55:33

wmayer

Details Diff
+ fixes 0001505: Fix multiple bugs in Idf.py Affected Issues
0001505
mod - src/Mod/Idf/Idf.py Diff File

FreeCAD: master e34c0f67

2014-04-13 16:34:14

wmayer

Details Diff
+ fixes 0001505: Fix multiple bugs in Idf.py Affected Issues
0001505
mod - src/Mod/Idf/Idf.py Diff File

Issue History

Date Modified Username Field Change
2014-04-13 10:41 nickoe New Issue
2014-04-13 10:41 nickoe File Added: 0001-Fix-multiple-bugs-in-Idf.py.patch
2014-04-13 10:49 nickoe File Added: bm.emn
2014-04-13 11:08 nickoe File Added: example-idf.zip
2014-04-13 11:51 wmayer Note Added: 0004552
2014-04-13 11:56 wmayer Summary Fix multibe bugs in Idf.py => Fix multiple bugs in Idf.py
2014-04-13 12:06 nickoe Note Added: 0004553
2014-04-13 12:18 wmayer Changeset attached => FreeCAD Master master be8c5938
2014-04-13 12:18 wmayer Assigned To => wmayer
2014-04-13 12:18 wmayer Status new => closed
2014-04-13 12:18 wmayer Resolution open => fixed
2014-04-13 12:25 nickoe Note Added: 0004554
2014-04-13 12:25 nickoe Status closed => feedback
2014-04-13 12:25 nickoe Resolution fixed => reopened
2014-04-13 12:32 nickoe Note Added: 0004555
2014-04-13 12:32 nickoe Status feedback => assigned
2014-04-13 14:04 wmayer Note Added: 0004556
2014-04-13 14:58 wmayer Changeset attached => FreeCAD Master master e34c0f67
2014-04-13 14:58 wmayer Status assigned => closed
2014-04-14 22:00 wmayer Relationship added related to 0001424