FreeCADView Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001872 | FreeCAD | Bug | public | 2014-12-22 00:42 | 2014-12-22 09:50 |
| Reporter | peterl94 | Assigned To | wmayer | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| OS | Windows | ||||
| Summary | 0001872: HAVE_CONFIG_H regression | ||||
| Description | Commit f0507331 reintroduced defining HAVE_CONFIG_H when OCE is found. This causes the build to fail on Windows, and is redundant on *nix. | ||||
| Tags | No tags attached. | ||||
| FreeCAD Information | |||||
|
|
It seems that this command has been around since using cmake (commit of 2009-06-26T11:56) Peter, are you suggesting to just remove the line add_definitions (-DHAVE_CONFIG_H) as you did in f13f5dc52098c02bc53ac7a4e625c8e0d8e1ae2e ? |
|
|
Yes, I am. Correct me if I'm wrong, but isn't it redundant since it gets set if GCC or Clang is used? |
|
FreeCAD: master f0507331 2014-11-21 23:43:51 Committer: shoogen Details Diff |
Fix OCE / OCC version detection. |
Affected Issues 0001872 |
|
| mod - CMakeLists.txt | Diff File | ||
| mod - cMake/FindOpenCasCade.cmake | Diff File | ||
| mod - cMake/FreeCadMacros.cmake | Diff File | ||
|
FreeCAD: master 5478c0fd 2014-12-22 10:24:26 Details Diff |
+ fixes 0001872: HAVE_CONFIG_H regression |
Affected Issues 0001872 |
|
| mod - cMake/FindOpenCasCade.cmake | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-12-22 00:42 | peterl94 | New Issue | |
| 2014-12-22 07:39 | shoogen | Changeset attached | => FreeCAD Master master f0507331 |
| 2014-12-22 07:53 | shoogen | Note Added: 0005433 | |
| 2014-12-22 07:58 | peterl94 | Note Added: 0005434 | |
| 2014-12-22 09:50 | wmayer | Changeset attached | => FreeCAD Master master 5478c0fd |
| 2014-12-22 09:50 | wmayer | Assigned To | => wmayer |
| 2014-12-22 09:50 | wmayer | Status | new => closed |
| 2014-12-22 09:50 | wmayer | Resolution | open => fixed |
