View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002587 | PartDesign | Bug | public | 2016-06-12 08:48 | 2016-06-18 08:18 |
Reporter | ulrich1a | Assigned To | eivindkvedalen | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
OS | Debian | OS Version | Jessie | ||
Product Version | 0.16 | ||||
Fixed in Version | 0.16 | ||||
Summary | 0002587: Angle Expressions deliver radiants with ° as unit | ||||
Description | Expressions, which refers to an angle, results in an angle in radiant with a degree unit. See also http://forum.freecadweb.org/viewtopic.php?f=3&t=16131#p127731 | ||||
Steps To Reproduce | - Make a sketch with a named angle constraint. - Define a second angle constraint in that sketch and put an expression in, which refers to the named angle constraint. The second angle constraint has a different angle than the named angle constraint. The problem can be seen in the attached file Angle_Expression_Problem_Sketch.fcstd | ||||
Tags | No tags attached. | ||||
FreeCAD Information | |||||
|
|
|
Please test https://github.com/eivindkv/free-cad-code/tree/Sketcher_fix_20160614 (rebased to current master), and see if this fixes the problem. This also adds units to sketcher constraints when used in expressions or from the spreadsheet. |
|
I compiled the branch. It solves the problem with the angle expression and as well the problem with the missing unit in the spreadsheet. |
FreeCAD: master 171fce7b 2016-06-13 20:27:48 Eivind Kvedalen Committer: wmayer Details Diff |
Sketcher: Fixed radian/degree mix-up for Angle constraint. |
Affected Issues 0002587 |
|
mod - src/Mod/Sketcher/App/Constraint.cpp | Diff File | ||
mod - src/Mod/Sketcher/Gui/TaskSketcherConstrains.cpp | Diff File | ||
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp | Diff File | ||
FreeCAD: master 7afcb4be 2016-06-14 01:13:33 Eivind Kvedalen Committer: wmayer Details Diff |
Sketcher: Changed return type of Constraint::getPresentationValue() to Quantity, to be able to include unit. |
Affected Issues 0002587 |
|
mod - src/Mod/Sketcher/App/Constraint.cpp | Diff File | ||
mod - src/Mod/Sketcher/App/Constraint.h | Diff File | ||
mod - src/Mod/Sketcher/Gui/TaskSketcherConstrains.cpp | Diff File | ||
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-06-12 08:48 | ulrich1a | New Issue | |
2016-06-12 08:48 | ulrich1a | File Added: Angle_Expression_Problem_Sketch.fcstd | |
2016-06-14 05:16 | eivindkvedalen | Note Added: 0007145 | |
2016-06-14 05:16 | eivindkvedalen | Assigned To | => eivindkvedalen |
2016-06-14 05:16 | eivindkvedalen | Status | new => assigned |
2016-06-16 20:17 | ulrich1a | Note Added: 0007152 | |
2016-06-18 08:17 | wmayer | Changeset attached | => FreeCAD Master master 7afcb4be |
2016-06-18 08:18 | wmayer | Changeset attached | => FreeCAD Master master 171fce7b |
2016-06-18 08:18 | wmayer | Status | assigned => closed |
2016-06-18 08:18 | wmayer | Resolution | open => fixed |
2016-06-18 08:18 | wmayer | Fixed in Version | => 0.16 |