FreeCADView Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003206 | Project Tools & Websites | General | public | 2017-10-01 12:29 | 2022-02-06 23:10 |
| Reporter | Kunda1 | Assigned To | Kunda1 | ||
| Priority | low | Severity | feature | Reproducibility | N/A |
| Status | assigned | Resolution | open | ||
| Target Version | 0.20 | ||||
| Summary | 0003206: TravisCI to run code linting to report trailing whitespace/tabs + LF line endings | ||||
| Description | Recently @wmayer expressed a way to remove trailing whitespaces and tabs in FC code. We could also think about avoiding more of them from being introduced in to source via testing when a PR is submitted. | ||||
| Tags | #pending, TravisCI, unit-test | ||||
| FreeCAD Information | |||||
|
|
How did he do this? AFAIK FEM is be free of trailing whitespaces and tabs. I remove them manually. For tabs I use: Would be cool if we could include this in travis and step by step add any clean source directory of FreeCAD to it. From my point it should be before any start of compiling on travis. bernd |
|
|
Here's a tut on Howto Automatically fix PEP-8 issues using Travis-CI Just can show us how to implement something in to travis |
|
|
Cause TravisCI to fail on any trailing whitespace https://coderwall.com/p/h988xa/cause-travis-to-fail-on-trailing-whitespace Add this to the script: section of .travis.yml |
|
|
@wmayer what do you think would be a good outcome if a PR is found to have trailing whitespace? Should it kill the build process and report to the user where the whitespace is? |
|
|
> what do you think would be a good outcome if a PR is found to have trailing whitespace? Detecting a trailing whitespace would be good but it should not abort the build process. |
|
|
FFmpeg has a cool script that checks patches: https://github.com/FFmpeg/FFmpeg/blob/master/tools/patcheck |
|
|
This can probably be handled via GitHub Actions now. |
|
|
A volunteer is working on this now |
|
|
'Floriansimmer' https://github.com/FreeCAD/FreeCAD/pull/5314#issuecomment-1019503744 |
|
|
This ticket has been migrated to GitHub as issue 5731. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-10-01 12:29 | Kunda1 | New Issue | |
| 2017-10-01 12:29 | Kunda1 | Tag Attached: TravisCI | |
| 2017-10-01 13:44 | Kunda1 | Tag Attached: unit-test | |
| 2017-10-01 20:11 | Kunda1 | Relationship added | related to 0003205 |
| 2017-10-01 20:39 | Kunda1 | Status | new => assigned |
| 2017-10-01 20:39 | Kunda1 | Assigned To | => Kunda1 |
| 2017-10-08 07:16 | berndhahnebach | Note Added: 0010262 | |
| 2017-10-08 07:17 | berndhahnebach | Note Edited: 0010262 | |
| 2017-10-08 07:17 | berndhahnebach | Note Edited: 0010262 | |
| 2017-10-08 07:17 | berndhahnebach | Note Edited: 0010262 | |
| 2017-10-08 07:17 | berndhahnebach | Note Edited: 0010262 | |
| 2017-10-09 19:27 | Kunda1 | Note Added: 0010274 | |
| 2017-10-14 18:41 | Kunda1 | Note Added: 0010297 | |
| 2017-10-16 14:27 | Kunda1 | Note Added: 0010301 | |
| 2017-10-17 18:12 | wmayer | Note Added: 0010311 | |
| 2017-10-19 13:10 | Kunda1 | Relationship added | related to 0001352 |
| 2017-10-19 13:11 | Kunda1 | Summary | TravisCI to run code linting to report trailing whitespace/tabs => TravisCI to run code linting to report trailing whitespace/tabs + LF line endings |
| 2017-11-10 14:25 | Kunda1 | Note Added: 0010405 | |
| 2017-11-12 17:26 | Kunda1 | Relationship added | child of 0003259 |
| 2021-02-06 06:36 | abdullah | Target Version | => 0.20 |
| 2021-12-17 03:54 | chennes | Note Added: 0016109 | |
| 2022-01-23 00:16 | Kunda1 | Relationship deleted | child of 0003259 |
| 2022-01-24 18:04 | Kunda1 | Note Added: 0016270 | |
| 2022-01-24 18:06 | Kunda1 | Tag Attached: #pending | |
| 2022-02-06 23:10 | Kunda1 | Note Added: 0016369 |
