FreeCADView Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001883 | FreeCAD | Bug | public | 2014-12-29 11:08 | 2015-01-21 13:27 |
| Reporter | shoogen | Assigned To | yorik | ||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Product Version | 0.15 | ||||
| Target Version | 0.15 | ||||
| Summary | 0001883: Wrong license for files lacking (predating) the license Property | ||||
| Description | Opening an existing file that lacks the license property, gets this property set to CC-BY when opening the file. | ||||
| Tags | No tags attached. | ||||
| FreeCAD Information | |||||
|
|
I think the culprit is src/App/Document.cpp, line 614/615. Probably the defaults for these two fields should indeed be set to "". I also think the creative commons license shouldn't be forced on the user. If nobody speaks against it, I'll do the change. Maybe the best of the best, would be a button, next to the license field, that says "Use CC 3.0", that would fill the fields with CC 3.0 info... (Or 4.0, which is the newest now) |
|
|
IMHO the default value for opening existing files should be "unknown" or "unspecified" "N/A". Whereas for NEW documents there should be a default, that the users should be able to adjust in the GUI. (But this would be in the scope of 0001766) |
|
|
I'm afraid that for existing documents it's too late... Their "license" field has already been filled, and now there is no way to differentiate them from files where the user would have specifically wished the CC3.0 license. I propose to go on with a "Unspecified" default value for now, because it's a quick fix, while issue 0001766 is not done ( I would do 0001766 too but I've never touched the STEP stuff before) |
|
|
> IMHO the default value for opening existing files should be "unknown" or "unspecified" "N/A" I don't think that it should be one of these values because what does it mean in the end? If the license is unclear then you have to treat it as proprietary anyway. So, IMO the default should be set to 'Proprietary'. Inkscape does have a panel to set a license and it offers proprietary (the default), the different CC versions, public domain, FreeArt, Open-Font license and Others. |
|
|
It is true that "unspecified" has in this case the same meaning as "proprietary". But is "proprietary" really a license? The word seems weird to me... It seems to me that it would be the same as saying "open-source license" (you would reply yes, but which one?) Maybe there would be a formula, something like "all rights reserved"? |
|
|
I think Yorik is right in that if no license has been specified then we should just say that. Blank field, not specified, unknown, etc. or similar. The implication is "look elsewhere" or "seek clarification". If that is seen as a problem then the longer term fix could be to have some sort of pop up, or whatever, that asks you to set a licence when the file is saved and a licence has not been detected. Of course a GUI tool to set the licence seems to me to be basic and important functionality, to be honest I had not realised it was not already there. :-) |
|
|
|
|
|
Now I see that I was confused...:-) There is a GUI tool to change the licence data for a FreeCAD file, as I had thought, I just tried it and it works in 0.14.3703. What there is not is a property to set for the DEFAULT licence to be inserted automatically into a new document when created..... which is what 0001766 is talking about. I Found in 0.14.7303 that if you change a value and don't save the document then FreeCAD does not warn you that the document has been altered and thus forgets the changes to the Licence fields ...but if you click on save before closing then FreeCAD does remember the changes made. |
|
|
It seems that "all rights reserved" is exactly what we want: http://en.wikipedia.org/wiki/All_rights_reserved Ok I propose then to: - add a preference setting for license and license URL - add a series of predefined choices (CC, CC-By, etc, taken from inkscape) - set the default license to "All rights reserved" - use the preference values on document creation. Unfortunately I don't know what to do for existing documents. Ok for everyone? Speak now or forever hold your peace :) |
|
|
Thanks Yorik! BTW: I get a "QMetaObject::connectSlotsByName: No matching signal for on_prefLicenseType_changed(int)" in the report view |
|
|
Ok got it... It was a naming problem. One cannot name signals or slots starting with "on_something" otherwise it messes with Qt's auto slot connecting http://www.qtforum.org/article/20685/connectslotsbyname.html?s=dccb07b0b80aa19aa773861bc1dbea8519764f13#post76950 |
|
|
> Unfortunately I don't know what to do for existing documents. If existing documents don't have a license note the default should be "All rights reserved" as we cannot (silently) force them to "accept" the CC or any other license. |
|
|
Unfortunately all old documents already have their license field filled because before this commit, on new doc creation, these values were filled by default with CC-3.0. What we could do is, on opening a file, if we detect such license, we ask what to do? But this is annoying, because it will be a hassle for all users, not only the authors of the files. Honestly I think there are not so many existing FreeCAD documents around, where this is a problem... Anyway the default is now "All rights reserved". If we open a document with the license fields empty, however, at the moment it will stay empty. But I don't think there are many of those... The user would have had to empty the fields manually... |
|
FreeCAD: master 645d176a 2015-01-20 23:01:14 Details Diff |
Added preference setting to set default Author & License - fixes 0001883 * added fields in Prefereces->Default->Document * new documents take the values of those fields |
Affected Issues 0001883 |
|
| mod - src/App/Document.cpp | Diff File | ||
| mod - src/Gui/DlgSettingsDocument.ui | Diff File | ||
| mod - src/Gui/DlgSettingsDocumentImp.cpp | Diff File | ||
| mod - src/Gui/DlgSettingsDocumentImp.h | Diff File | ||
|
FreeCAD: master 378deaf7 2015-01-21 00:23:34 Details Diff |
Fixed small naming error - fixes 0001883 |
Affected Issues 0001883 |
|
| mod - src/Gui/DlgSettingsDocumentImp.cpp | Diff File | ||
| mod - src/Gui/DlgSettingsDocumentImp.h | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-12-29 11:08 | shoogen | New Issue | |
| 2014-12-29 14:55 | yorik | Note Added: 0005463 | |
| 2014-12-29 14:55 | yorik | Assigned To | => yorik |
| 2014-12-29 14:55 | yorik | Status | new => assigned |
| 2014-12-29 16:24 | shoogen | Note Added: 0005465 | |
| 2014-12-29 20:39 | yorik | Note Added: 0005468 | |
| 2014-12-30 10:58 | shoogen | Relationship added | related to 0001766 |
| 2015-01-10 11:42 | wmayer | Note Added: 0005605 | |
| 2015-01-10 13:38 | yorik | Note Added: 0005607 | |
| 2015-01-11 13:49 | jmaustpc | Note Added: 0005613 | |
| 2015-01-11 14:10 | jmaustpc | File Added: licence.jpeg | |
| 2015-01-11 14:24 | jmaustpc | Note Added: 0005614 | |
| 2015-01-19 17:25 | yorik | Note Added: 0005677 | |
| 2015-01-20 22:20 | yorik | Changeset attached | => FreeCAD Master master 645d176a |
| 2015-01-20 22:20 | yorik | Status | assigned => closed |
| 2015-01-20 22:20 | yorik | Resolution | open => fixed |
| 2015-01-20 22:31 | shoogen | Note Added: 0005681 | |
| 2015-01-20 22:31 | shoogen | Status | closed => feedback |
| 2015-01-20 22:31 | shoogen | Resolution | fixed => reopened |
| 2015-01-20 23:25 | yorik | Note Added: 0005682 | |
| 2015-01-20 23:39 | yorik | Changeset attached | => FreeCAD Master master 378deaf7 |
| 2015-01-20 23:39 | yorik | Status | feedback => closed |
| 2015-01-21 10:10 | wmayer | Note Added: 0005685 | |
| 2015-01-21 13:27 | yorik | Note Added: 0005686 |
