View Issue Details

IDProjectCategoryView StatusLast Update
0003046FreeCADBugpublic2017-05-26 21:08
Reporterglockpod Assigned To 
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionno change required 
PlatformDell Precision T3500OSDebian LinuxOS VersionWheezy
Product Version0.17 
Summary0003046: Wrong number of template arguments NCollection_DataMap<>
DescriptionI am working under Linux Wheezy, having cloned FreeCAD from the git hub, and now using the latest pull from the github.

All compile requirements are satisfied, according to CMake.

After running make, the compile fails with:
=======================================
Now run 'make' to build FreeCAD
=======================================

-- Configuring done
-- Generating done
-- Build files have been written to: /home/chuck/FreeCAD/free-cad-code
chuck@glockpod:~/FreeCAD/free-cad-code$ make
[ 1%] Built target SMDS
[ 1%] Built target MEFISTO2
[ 1%] Building CXX object src/3rdParty/salomesmesh/CMakeFiles/SMESHDS.dir/src/SMESHDS/SMESHDS_Document.cpp.o
In file included from /home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/inc/SMESHDS_Document.hxx:32:0,
                 from /home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/src/SMESHDS/SMESHDS_Document.cpp:29:
/home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/inc/SMESHDS_Mesh.hxx:62:69: error: wrong number of template arguments (3, should be 2)
In file included from /home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/inc/SMESHDS_Mesh.hxx:59:0,
                 from /home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/inc/SMESHDS_Document.hxx:32,
                 from /home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/src/SMESHDS/SMESHDS_Document.cpp:29:
/usr/lib/oce-0.9.1/../../include/oce/NCollection_DataMap.hxx:39:54: error: provided for ‘template<class TheKeyType, class TheItemType> class NCollection_DataMap’
In file included from /home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/inc/SMESHDS_Document.hxx:32:0,
                 from /home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/src/SMESHDS/SMESHDS_Document.cpp:29:
/home/chuck/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/inc/SMESHDS_Mesh.hxx:62:88: error: invalid type in declaration before ‘;’ token
make[2]: *** [src/3rdParty/salomesmesh/CMakeFiles/SMESHDS.dir/src/SMESHDS/SMESHDS_Document.cpp.o] Error 1
make[1]: *** [src/3rdParty/salomesmesh/CMakeFiles/SMESHDS.dir/all] Error 2
make: *** [all] Error 2

-----

Checking Git just in case something has changed:

chuck@glockpod:~/FreeCAD/free-cad-code$ git pull
Already up-to-date.

---

After wading through the FreeCAD source, it is apparent that this is the problem area:

chuck@glockpod:~/FreeCAD/free-cad-code/src/3rdParty/salomesmesh/inc$ grep -n "NCollection_DataMap" *.hxx
GEOMUtils.hxx:39:#include <NCollection_DataMap.hxx>
GEOMUtils.hxx:116: typedef NCollection_DataMap<TopoDS_Shape, std::pair<double, double> > GEOMUtils_DataMapOfShapeDouble;
SMESHDS_DataMapOfShape.hxx:33: * This method needed for instance NCollection_DataMap with TopoDS_Shape as key
SMESHDS_Mesh.hxx:57: * So this functionality implement on new NCollection_DataMap technology
SMESHDS_Mesh.hxx:59:#include <NCollection_DataMap.hxx>
SMESHDS_Mesh.hxx:62:typedef NCollection_DataMap< TopoDS_Shape, THypList, SMESHDS_Hasher > ShapeToHypothesis;
----
Two different ideas of what the arguments for NCollection_DataMap<>
should be.

I'm not sure how this was missed, as you all seem to be making changes, and gliding right by the problem...

-Chuck

Steps To ReproduceDebian Wheezy with all of the latest upgrades,


1)Install the necessary requirements per the Unix compile on this website
2) git clone https://github.com/FreeCAD/FreeCAD.git free-cad-code
3) cmake -DFREECAD_USE_EXTERNAL_PIVY=1 -DCMAKE_BUILD_TYPE=Release
4) make

And the failure appears.
TagsNo tags attached.
FreeCAD Information

Activities

Kunda1

2017-05-23 16:24

administrator   ~0009100

Please open a forum thread per https://forum.freecadweb.org/viewtopic.php?f=3&t=5236

glockpod

2017-05-23 16:43

reporter   ~0009101

Hmm, I tried to open a forum thread, per your link, but how one does that truly isn't obvious to me. "Report Issue" is right there on the side of this screen for all to see, Open a forum thread is nowhere to be found.

But no matter,

I did all of the things the link you referenced asked:

I checked to see if the problem had been reported, it hadn't.
I made sure I was using the latest FreeCAD version, I was.
I didn't just think it might be a bug, it is a bug.
I showed how to reveal the problem.
I showed exactly where in the FreeCAD source the problem was.

I would fix it myself, but I thought I would try to give something back to the community, I guess protocol is more important.... though not important enough to make opening a thread easily done.

So what is the problem? Do you want to know about this bug, or not?

-Chuck

Kunda1

2017-05-23 19:27

administrator   ~0009103

@glockpod thanks for making the effort to report an issue. That's not something we want to discourage. Just the opposite we welcome the feedback. The issue here is more on our end to make it more streamlined for the community to troubleshoot issues. Most of the activity of the FC community is via the forums. In other words you would get way more exposure and potentially faster response times posting directly to it. There are very few active bugtracker volunteers. That's the gist.

The forum to post in would be the Install and Compile section: https://forum.freecadweb.org/viewforum.php?f=4

glockpod

2017-05-23 19:49

reporter   ~0009105

Ok, thanks. I have submitted my issue to the Compile/Install forum. I think I have introduced some typo's in my attempt at recreating the above report there, but I hope it won't be too bad.

-Chuck

Kunda1

2017-05-23 20:35

administrator   ~0009106

Forum thread: https://forum.freecadweb.org/viewtopic.php?f=4&t=22617

Kunda1

2017-05-24 07:12

administrator   ~0009108

Resolving issue per ickby in https://forum.freecadweb.org/viewtopic.php?f=4&t=22617&p=175296#p175296
Reason: inferior OCC version being used.

Issue History

Date Modified Username Field Change
2017-05-23 13:05 glockpod New Issue
2017-05-23 16:24 Kunda1 Note Added: 0009100
2017-05-23 16:43 glockpod Note Added: 0009101
2017-05-23 19:27 Kunda1 Note Added: 0009103
2017-05-23 19:49 glockpod Note Added: 0009105
2017-05-23 20:35 Kunda1 Note Added: 0009106
2017-05-24 07:12 Kunda1 Status new => resolved
2017-05-24 07:12 Kunda1 Resolution open => no change required
2017-05-24 07:12 Kunda1 Note Added: 0009108
2017-05-26 21:08 Kunda1 Status resolved => closed