View Issue Details

IDProjectCategoryView StatusLast Update
0003275PathBugpublic2018-01-23 18:56
ReporterJoshM Assigned Tosliptonic  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformWindowsOSMicrosoft WindowsOS VersionWindows 10
Product Version0.17 
Summary0003275: Path Custom-GCode Splits Comments, introducing errors
DescriptionCustom GCode splits comments across Rows in some cases. This is a bit nuanced, and I've been trying to isolate it. I thought it was based on the Width of the editor, but can't say for sure. This causes my CNC-Control software to "Hang" when run, though it doesn't generate an Error in Path-WB.
Steps To ReproduceUse Path-WB's Custom-GCode Tool from the Path->Partial Commands sub-menu. The default width is narrow. Type a long comment which will get split across Rows. Note that the final GCode will have a Row containing comment-text, but with the preceding "(" comment delineation on the previous row.
Additional InformationVerified by Sliptonic in: https://forum.freecadweb.org/viewtopic.php?f=15&t=25511&start=10


OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.12643 (Git)
Build type: Release
Branch: master
Hash: 868d9cc6c215ce3a2ab20d454378ec00e1b9ed26
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.1.0
Locale: English/UnitedStates (en_US)
TagsPath
FreeCAD Information

Activities

sliptonic

2017-11-28 00:18

manager   ~0010480

I'm pretty sure I verified this but I can't repeat it now. The lines seem to be wrapping normally. That is, when the editor is narrow, they break and wrap, but the final output is a single long line.

I verifying this by examining the path commands in the custom editor, but also in the display window at post process time and also in the output .tap file. In all cases, it's a single long line.

Gcode, at least in linuxcnc, has a maximum line length of 256 characters. If the line is longer than that, it just won't load.

I suppose if very long comment lines (greater than 256) are needed, the linuxcnc post can be modified to automatically break them at 256. Is it worth it?

sliptonic

2018-01-04 16:10

manager   ~0010701

joshm can you weigh in again. Can you repeat this reliably?

JoshM

2018-01-04 18:14

reporter   ~0010702

I just tried that again, and cannot reproduce at this time.

Were there always line numbers displayed in the GCode-Inspection and Custom-GCode windows? The lines are splitting and numbers reflect correctly.

I also tried COPY/PASTE between Inspection and Custom and Post-Processor windows but cannot induce an error.

sliptonic

2018-01-22 06:29

manager   ~0010812

unable to reproduce problem anymore

Kunda1

2018-01-23 18:56

administrator   ~0010830

Closing

Issue History

Date Modified Username Field Change
2017-11-27 14:24 JoshM New Issue
2017-11-27 14:24 JoshM Tag Attached: Path
2017-11-27 20:33 Kunda1 Project FreeCAD => Path
2017-11-28 00:18 sliptonic Note Added: 0010480
2018-01-04 16:10 sliptonic Note Added: 0010701
2018-01-04 18:14 JoshM Note Added: 0010702
2018-01-22 06:29 sliptonic Assigned To => sliptonic
2018-01-22 06:29 sliptonic Status new => resolved
2018-01-22 06:29 sliptonic Resolution open => fixed
2018-01-22 06:29 sliptonic Note Added: 0010812
2018-01-23 18:56 Kunda1 Status resolved => closed
2018-01-23 18:56 Kunda1 Note Added: 0010830