0004510: Do not transfer Equal constraints to remaining edges after a trimming operation

ID	Project	Category	View Status	Date Submitted	Last Update

0004510	Sketcher	Feature	public	2020-12-14 17:49	2020-12-21 08:20

Reporter	davidosterberg	Assigned To	abdullah
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed

Summary	0004510: Do not transfer Equal constraints to remaining edges after a trimming operation
Description	Currently trimmed edges "inherit" the Equal constraint from the original edge. This is undesirable (wrong), because the trimmed edge is always shorter than the untrimmed edge. This leads to the sketch getting distorted (as in attached gif) Forum discussion: https://forum.freecadweb.org/viewtopic.php?f=8&t=53240
Steps To Reproduce	1.) Open attached freecad file. 2.) Trim the edge as in the attached gif 3.) Observe how Constraint11 is transferred to the left of the two new edges after trimming. Desired behavior is that the star shape is maintained. I.e Constraint11 should be removed as part of the trim operation.
Tags	No tags attached.

FreeCAD Information	OS: Ubuntu 20.10 (KDE/plasma) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.19.23323 (Git) AppImage Build type: Release Branch: master Hash: 512d5c6141aec52b6eecc67370336a28fde862a6 Python version: 3.8.6 Qt version: 5.12.5 Coin version: 4.0.0 OCC version: 7.4.0 Locale: English/United States (en_US)

davidosterberg 2020-12-14 17:49 reporter	weird_sketcher_trim_behavior_simpliied.gif (210,770 bytes) weird_sketcher_trim_behavior_simpliied.gif (210,770 bytes) weird_sketcher_trim_simplified.FCStd (7,366 bytes)

davidosterberg 2020-12-15 12:01 reporter ~0015145	I have created a PR: https://github.com/FreeCAD/FreeCAD/pull/4147 fix.gif (158,537 bytes) fix.gif (158,537 bytes)

Kunda1 2020-12-21 08:07 administrator ~0015164 Last edited: 2020-12-21 08:16	FreeCAD master edb87a06 FreeCAD master bfc036da FreeCAD master a8443b6b

Kunda1 2020-12-21 08:20 administrator ~0015165	Associated commits to ticket. Thanks to @davidosterberg @chennes and @abdullah Closing ticket

FreeCAD: master edb87a06 2020-12-15 11:44:19 davidosterberg Committer: abdullahtahiriyo Details Diff	Delete Equal constraints on LineSegments in SketchObject::trim This closes: https://tracker.freecadweb.org/view.php?id=4510	Affected Issues 0004510
	mod - src/Mod/Sketcher/App/SketchObject.cpp	Diff File
FreeCAD: master bfc036da 2020-12-15 15:55:25 davidosterberg Committer: abdullahtahiriyo Details Diff	Update src/Mod/Sketcher/App/SketchObject.cpp Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>	Affected Issues 0004510
	mod - src/Mod/Sketcher/App/SketchObject.cpp	Diff File
FreeCAD: master a8443b6b 2020-12-16 09:51:22 davidosterberg Committer: abdullahtahiriyo Details Diff	Improve comment and remove uncessary return statement	Affected Issues 0004510
	mod - src/Mod/Sketcher/App/SketchObject.cpp	Diff File

Date Modified	Username	Field	Change
2020-12-14 17:49	davidosterberg	New Issue
2020-12-14 17:49	davidosterberg	File Added: weird_sketcher_trim_behavior_simpliied.gif
2020-12-14 17:49	davidosterberg	File Added: weird_sketcher_trim_simplified.FCStd
2020-12-14 19:40	davidosterberg	Summary	Do not transfer equality constraints from to remaining edge after a trimming operation => Do not transfer Equal constraints to remaining edges after a trimming operation
2020-12-14 19:40	davidosterberg	Description Updated
2020-12-15 12:01	davidosterberg	Note Added: 0015145
2020-12-15 12:01	davidosterberg	File Added: fix.gif
2020-12-21 08:07	Kunda1	Note Added: 0015164
2020-12-21 08:08	Kunda1	Changeset attached	=> FreeCAD master edb87a06
2020-12-21 08:16	Kunda1	Note Edited: 0015164
2020-12-21 08:17	Kunda1	Changeset attached	=> FreeCAD master bfc036da
2020-12-21 08:18	Kunda1	Changeset attached	=> FreeCAD master a8443b6b
2020-12-21 08:20	Kunda1	Assigned To	=> abdullah
2020-12-21 08:20	Kunda1	Status	new => closed
2020-12-21 08:20	Kunda1	Resolution	open => fixed
2020-12-21 08:20	Kunda1	Fixed in Version	=> 0.19
2020-12-21 08:20	Kunda1	Note Added: 0015165