All Projects FreeCAD  Addon Manager  Arch  Assembly  Draft  Expressions  FEM  File formats  GCS  OpenSCAD  Part  PartDesign  Path  Project Tools & Websites  Raytracing  Robot  Sketcher  Spreadsheet  TechDraw

View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004547PathBugpublic2021-01-30 22:342021-02-17 15:33
Reporterfremen Assigned Tosliptonic  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionwon't fix 
Target Version0.20 
Summary0004547: pointless dialogue when adding new tool to job
Descriptionhttps://forum.freecadweb.org/viewtopic.php?f=15&t=54960
Steps To Reproduceenter Job Edit dlg, Tool tab
click Add btn
click checkbox on an existing tool
click on "create toolcontroller(s)" btn

A dlg "Copy Selected Tools" dlg comes up with a drop down list. Only one element is selectable.

whatever is selected, or even if Cancel btn is clicked the TC goes into current job. This dlg is a total waste of time and is just an annoying hindrance to work flow.

Looking at the code it seems there may have been some intent to allow user to select multiple jobs to add the new TC to. This could conceivably be useful since multiple jobs could be required to do similar things with different orientations of the work piece and may need the same tool.

It's currently useless but may just need fixing.

I'm guessing the aim was to have it automatically select the current job, so user can just OK it, or provide the user a way to create similar TCs in several jobs at one time. This would require a multiple selection widget, not the current dropdown listbox.

Currently cancelling the dlg and cancelling the Toolcontroller edit dlg itself still gets you a new TC in current job.




Additional Information
            ### get rid of useless dlg
            form = FreeCADGui.PySideUic.loadUi(":/panels/DlgToolCopy.ui")
            form.cboTarget.addItems(targets)
            r = form.exec_()
            if r is False:
                return None
            else:
                targetlist = form.cboTarget.currentText()
TagsNo tags attached.
FreeCAD InformationOS: Fedora 31 (Thirty One) (LXDE/LXDE)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.23777 (Git)
Build type: Release
Branch: master
Hash: dbaa2c1ba458d34244420037d4ff91b3841411ce
Python version: 3.7.9
Qt version: 5.13.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/United Kingdom (en_GB)

Activities

sliptonic

2021-02-17 15:33

manager   ~0015364

This only applies to legacy tools. With the new toolbit system, the user is shown a dialog of toolbits from their selected 'Bit' directory. They pick one and it's added to the current job.

Changing status to won't fix since legacy tools will be deprecated anyway.

Issue History

Date Modified Username Field Change
2021-01-30 22:34 fremen New Issue
2021-02-06 06:33 abdullah Target Version => 0.20
2021-02-11 17:47 Kunda1 Summary pointless dialogue wnen adding new tool to job => pointless dialogue when adding new tool to job
2021-02-11 17:47 Kunda1 FreeCAD Information OS: Fedora 31 (Thirty One) (LXDE/LXDE) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.19.23777 (Git) Build type: Release Branch: master Hash: dbaa2c1ba458d34244420037d4ff91b3841411ce Python version: 3.7.9 Qt version: 5.13.2 ... => OS: Fedora 31 (Thirty One) (LXDE/LXDE) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.19.23777 (Git) Build type: Release Branch: master Hash: dbaa2c1ba458d34244420037d4ff91b3841411ce Python version: 3.7.9 Qt version: 5.13.2 Co...
2021-02-17 15:33 sliptonic Assigned To => sliptonic
2021-02-17 15:33 sliptonic Status new => closed
2021-02-17 15:33 sliptonic Resolution open => won't fix
2021-02-17 15:33 sliptonic Note Added: 0015364