View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002034 | Part | Bug | public | 2015-03-31 12:57 | 2019-07-30 22:48 |
Reporter | toehser | Assigned To | yorik | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | reopened | ||
Platform | Ubuntu 14.04.2 x64 | OS | Linux | OS Version | 3.13.0-49-generi |
Product Version | 0.17 | ||||
Fixed in Version | 0.18 | ||||
Summary | 0002034: Measurement arrowheads are ridiculously out of proportion at some scales/zooms/measurements. | ||||
Description | See http://www.toms.net/FreeCAD/fc2.png (attached to ticket) | ||||
Steps To Reproduce | measure something small | ||||
Additional Information | arrowheads even overlap into hourglasses | ||||
Tags | #lowhangingfruit, #pending | ||||
FreeCAD Information | |||||
|
Please retest on 0.16 Forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=20175 Edit: Another thread found at https://forum.freecadweb.org/viewtopic.php?f=3&t=7126 |
|
I confirm this bug in current master. Steps to reproduce: 1. Create a Part Cube of dimensions 0.1 x 0.1 x 0.1 mm 2. Select two vertices 3. Click on "Measure Linear" from the Measure toolbar in the Part workbench 4. The measurement arrows are disproportionally huge. OS: Ubuntu 14.04.5 LTS Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.17.9747 (Git) Build type: None Branch: master Hash: f5c0f579cbd7ce668727f8835946e4e9abc0eec6 Python version: 2.7.6 Qt version: 4.8.6 Coin version: 4.0.0a OCC version: 6.8.0.oce-0.17 |
|
Changing status to 'confirmed' |
|
Copypasta from https://forum.freecadweb.org/viewtopic.php?f=3&t=7126#p157425
|
|
Re-added attached photo |
|
I have made an attempt to fix this bug. The code is available at: https://github.com/craig9/FreeCAD/tree/bug2034 Please let me know if I haven't followed the standard procedure in any way. (Or if the fix is no good) Cheers, Craig |
|
The fix looks good, I just merged it. Thanks! |
|
https://github.com/FreeCAD/FreeCAD/commit/690774c0effe4fd7b8d2b5e2fb2b8c8d145e21ce |
|
Unfortunately, this issue is not correctly solved. When creating a cube of size 0.1 x 0.1 x 0.1 then the arrows are not correctly placed. The peaks of the arrows should lie on the selected points. |
|
Thanks wmayer for pointing that out. I looked into it a little further, and there was a precision error, so I've increased that by four decimals, which gives good results at 0.1mm, and acceptable results at 10nm. Going much further would require using a double instead of a float, and I'm not sure whether there would be any knock-on effects. https://github.com/FreeCAD/FreeCAD/pull/2016 Update: Please excuse the git mess, I neglected to rebase first, so there are a few commits that may not make sense, but the end result should be good. I'm learning git as I go, and there seems to be a bit of an art to fetching and merging and pushing from/to different sources. If you'd like me to create a new branch to keep the history clean, that's fine, just let me know. |
|
Thanks for providing a fix. I think it's sufficient the way how it works now because when entering value of 1nm or lower (or for very huge values) then the whole scene starts to behave weirdly. This is because OpenInventor only uses floats. About git: I was able to cherry-pick the last commit which includes the relevant changes. |
|
Thanks wmayer. And - thanks for the reminder about the cherry pick feature within git. I will look into that. |
|
https://github.com/FreeCAD/FreeCAD/commit/23ecb8eace2f59049bf52106f694c3b4c2d6eb7a |
FreeCAD: releases/FreeCAD-0-18 690774c0 2019-03-11 02:00:30 Craig Marshall Committer: Yorik van Havre Details Diff |
Fixes Bug 2034. Made Part dimensional arrows proportional to line length and radius |
Affected Issues 0002034 |
|
mod - src/Mod/Part/Gui/TaskDimension.cpp | Diff File | ||
mod - src/Mod/Part/Gui/TaskDimension.h | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-03-31 12:57 | toehser | New Issue | |
2017-01-24 00:21 | Kunda1 | File Added: fc2.png | |
2017-01-24 00:21 | Kunda1 | Description Updated | |
2017-01-24 00:28 | Kunda1 | Note Added: 0007941 | |
2017-01-24 00:28 | Kunda1 | Status | new => feedback |
2017-01-24 00:29 | Kunda1 | Tag Attached: #pending | |
2017-01-24 04:15 | normandc | Note Added: 0007943 | |
2017-01-30 13:39 | Kunda1 | Note Added: 0008102 | |
2017-01-30 13:39 | Kunda1 | Status | feedback => confirmed |
2017-01-30 20:03 | Kunda1 | Note Edited: 0007941 | |
2017-02-01 23:56 | Kunda1 | Tag Attached: #lowhangingfruit | |
2017-03-10 00:16 | Kunda1 | Note Added: 0008601 | |
2017-03-10 00:18 | Kunda1 | Note Edited: 0008601 | |
2017-03-10 00:21 | Kunda1 | Product Version | => 0.17 |
2017-03-10 00:21 | Kunda1 | Target Version | => 0.17 |
2017-05-01 22:59 | Kunda1 | File Deleted: fc2.png | |
2017-05-01 23:00 | Kunda1 | File Added: IMG_0010.PNG | |
2017-05-01 23:00 | Kunda1 | Note Added: 0008841 | |
2017-06-27 11:31 | Kunda1 | Relationship added | related to 0002520 |
2017-10-18 14:21 | wmayer | Project | FreeCAD => Part |
2018-01-05 21:11 | wmayer | Target Version | 0.17 => 0.18 |
2019-02-14 21:29 | wmayer | Target Version | 0.18 => 0.19 |
2019-03-11 02:05 | craig9 | Note Added: 0012878 | |
2019-03-12 13:38 | yorik | Note Added: 0012894 | |
2019-03-12 13:39 | yorik | Assigned To | => yorik |
2019-03-12 13:39 | yorik | Status | confirmed => closed |
2019-03-12 13:39 | yorik | Resolution | open => fixed |
2019-03-12 13:39 | yorik | Fixed in Version | => 0.18 |
2019-03-12 13:39 | yorik | Note Added: 0012895 | |
2019-03-12 16:54 | wmayer | Status | closed => new |
2019-03-12 16:54 | wmayer | Resolution | fixed => reopened |
2019-03-12 16:54 | wmayer | Note Added: 0012897 | |
2019-03-12 21:31 | craig9 | Note Added: 0012903 | |
2019-03-12 21:33 | craig9 | Note Edited: 0012903 | |
2019-03-12 22:30 | craig9 | Note Edited: 0012903 | |
2019-03-14 22:40 | wmayer | Note Added: 0012907 | |
2019-03-14 22:43 | craig9 | Note Added: 0012908 | |
2019-03-14 22:49 | wmayer | Status | new => closed |
2019-03-14 22:49 | wmayer | Note Added: 0012909 | |
2019-07-30 22:48 | Kunda1 | Changeset attached | => FreeCAD releases/FreeCAD-0-18 690774c0 |