0004080: Draft upgrade make face fails with a sketch contatining multiple closed loops - FreeCAD Tracker

NOTICE: Migration to GitHub Issues

On Feb 7, 2022, the FreeCAD project migrated all issues from this site at tracker.freecad.org to our main GitHub repository. All new bugs must be submitted there.
This Mantis repository is in read-only mode and will be retained for reference as long as it is useful.

For details please see the announcement at the Forums: https://forum.freecadweb.org/viewtopic.php?p=555883#p555883

ID	Project	Category	View Status	Date Submitted	Last Update

0004080	Draft	Bug	public	2019-08-07 07:18	2020-12-01 11:22

Reporter	dimitar	Assigned To
Priority	normal	Severity	feature	Reproducibility	always
Status	closed	Resolution	fixed
Platform	Linux	OS	Ubuntu 19.04	OS Version	19.04

Summary	0004080: Draft upgrade make face fails with a sketch contatining multiple closed loops
Description	The draft upgrade tool works well with creating a face from a sketch of single enclosed element. However, it does not work to create surfaces from a sketch with multiple enclosed elements. Here is the message from the report view: `Traceback (most recent call last): File "/usr/share/freecad-daily/Mod/Draft/Draft.py", line 4867, in execute shape = Part.Face(shape) <class 'Part.OCCError'>: Argument list signature is incorrect. Supported signatures: (face) (wire) (face, wire) (surface, wire) (list_of_wires) (wire, facemaker_class_name) (list_of_wires, facemaker_class_name) (surface, list_of_wires)`
Steps To Reproduce	Create a sketch in sketcher containing multiple closed areas Go to draft workbench and upgrade the sketch. By default, with the "make face" property set to true, the command fails If setting "make face" to false, to command works.
Additional Information	OS: Ubuntu 19.04 (ubuntu:GNOME/ubuntu) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.19. Build type: Release Python version: 3.7.3 Qt version: 5.12.2 Coin version: 4.0.0a OCC version: 7.3.0 Locale: English/United Kingdom (en_GB)
Tags	No tags attached.

FreeCAD Information

dimitar 2019-08-07 07:18 reporter	2019-08-07_08-11.png (13,801 bytes) 2019-08-07_08-11.png (13,801 bytes)

dimitar 2019-08-07 07:20 reporter ~0013402	As discussed here, where to make the example work, the elements had to be converted to solids. https://forum.freecadweb.org/viewtopic.php?f=3&t=38280

marioalexis 2020-11-25 10:30 developer ~0015020	Fix committed to master branch.

Kunda1 2020-12-01 11:22 administrator ~0015032	Closing ticket. Thanks @marioalexis!

FreeCAD: master 8e080f1d 2020-11-16 04:56:50 marioalexis Details Diff	Draft: Some fixes in upgrade function. bug 0004460, fixes 0004462, 0004080		Affected Issues 0004080, 0004460, 0004462
	mod - src/Mod/Draft/DraftGeomUtils.py		Diff File
	mod - src/Mod/Draft/draftfunctions/upgrade.py		Diff File
	mod - src/Mod/Draft/draftgeoutils/faces.py		Diff File

Date Modified	Username	Field	Change
2019-08-07 07:18	dimitar	New Issue
2019-08-07 07:18	dimitar	File Added: 2019-08-07_08-11.png
2019-08-07 07:20	dimitar	Note Added: 0013402
2020-11-25 10:30	marioalexis	Changeset attached	=> FreeCAD master 8e080f1d
2020-11-25 10:30	marioalexis	Note Added: 0015020
2020-12-01 11:22	Kunda1	Status	new => closed
2020-12-01 11:22	Kunda1	Resolution	open => fixed
2020-12-01 11:22	Kunda1	Note Added: 0015032
2020-12-01 11:22	Kunda1	Fixed in Version	=> 0.19