Changesets: FreeCAD

master 65656f6d

2021-02-05 00:38:34

uwestoehr


Committer: wmayer Details Diff
[Sketcher] make more pointers to the UI std::unique_ptr

addendum to PR 0004362

(Same as PR 0004293, just for Sketcher

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all Sketcher dialogs that don't already use a unique_ptr.)
mod - src/Mod/Sketcher/Gui/SketchMirrorDialog.cpp Diff File
mod - src/Mod/Sketcher/Gui/SketchMirrorDialog.h Diff File
mod - src/Mod/Sketcher/Gui/SketchOrientationDialog.cpp Diff File
mod - src/Mod/Sketcher/Gui/SketchOrientationDialog.h Diff File
mod - src/Mod/Sketcher/Gui/SketchRectangularArrayDialog.cpp Diff File
mod - src/Mod/Sketcher/Gui/SketchRectangularArrayDialog.h Diff File
mod - src/Mod/Sketcher/Gui/SketcherRegularPolygonDialog.cpp Diff File
mod - src/Mod/Sketcher/Gui/SketcherRegularPolygonDialog.h Diff File
mod - src/Mod/Sketcher/Gui/SketcherSettings.cpp Diff File
mod - src/Mod/Sketcher/Gui/SketcherSettings.h Diff File

master 75dee2ff

2021-02-04 21:51:39

aapo


Committer: wwmayer Details Diff
[TD] Fix XSource handling of sub-objects of links to another document(s) in TD Views.
mod - src/Mod/TechDraw/Gui/Command.cpp Diff File

master d9e7ee46

2021-02-04 17:23:41

amrit3701

Details Diff
Draft: Fix bug in getCubicDimensions function
mod - src/Mod/Draft/draftgeoutils/cuboids.py Diff File

master 656c4919

2021-02-04 14:31:06

wmayer

Details Diff
Qt4: [skip ci] fix build failure
mod - src/Mod/Sketcher/Gui/DrawSketchHandler.cpp Diff File

master 6d035737

2021-02-04 13:37:01

luz paz


Committer: abdullahtahiriyo Details Diff
Fix typo in previous commit 7add058dc [skip ci]

Removed superfluous double-quote char. (7add058dc)
mod - lgtm.yml Diff File

master 5903ff44

2021-02-04 12:56:15

wmayer

Details Diff
FEM: add basic support of Nastran-95
mod - src/Mod/Fem/App/FemMesh.cpp Diff File

master 7add058d

2021-02-04 11:32:47

luz paz


Committer: wwmayer Details Diff
LGTM: exclude zipios++ and kdl (orocos) libraries from analysis

Ref: https://lgtm.com/help/lgtm/lgtm.yml-configuration-file
mod - lgtm.yml Diff File

master 28c66fc5

2021-02-04 03:41:06

uwestoehr


Committer: wwmayer Details Diff
[Sketcher] make pointers to the UI std::unique_ptr

Same as PR 0004293, just for Sketcher

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all Sketcher dialogs that don't already use a unique_ptr.
mod - src/Mod/Sketcher/Gui/TaskSketcherConstrains.cpp Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherConstrains.h Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherElements.cpp Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherElements.h Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherGeneral.cpp Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherGeneral.h Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherMessages.cpp Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherMessages.h Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherSolverAdvanced.cpp Diff File
mod - src/Mod/Sketcher/Gui/TaskSketcherSolverAdvanced.h Diff File

master cc6099b7

2021-02-04 01:02:38

sliptonic


Committer: GitHub Details Diff
Merge pull request 0004262 from Schildkroet/adaptive_improve

[PATH] Adaptive improve helix entry
mod - src/Mod/Path/PathScripts/PathAdaptive.py Diff File
mod - src/Mod/Path/PathScripts/PathAdaptiveGui.py Diff File

master 64fb634e

2021-02-03 22:12:05

chennes


Committer: wwmayer Details Diff
Add tooltip to f(x) when there is no expression

As suggested by @luzpaz, this adds a tooltip to the f(x) icon of all
of the widgets that use it: QuantitySpinBox, UIntSpinBox, IntSpinBox,
DoubleSpinBox, and ExpLineEdit. These five classes are divided across
three files, and all five classes duplicate the same basic code. In the
existing code, no tooltip is shown if there is no expression. If there
is an expression, it (alone) is used as the tooltip.

This commit modifies that behavior to have explanatory text as the
tooltip when there is no expression, and when there is, to prepend a
short string to the beginning.

To reduce further code duplication, this is implemented by adding a new
function to ExpressionLabel allowing the text of the expression to be set.
It checks that text and if it's empty, uses a preset default string as the
tooltip. If there is expression text, it instead prepends another
bit of text to the front and sets the entire expression+prefix as the
tooltip.

TODO: In the future a lot of the preexisting code duplication could be
removed by making the ExpressionLabel class do more internal management
of the expression.

Thanks to @kisolre for the assistance tracking these down, and
suggesting the default text used.
mod - src/Gui/QuantitySpinBox.cpp Diff File
mod - src/Gui/QuantitySpinBox_p.h Diff File
mod - src/Gui/SpinBox.cpp Diff File
mod - src/Gui/Widgets.cpp Diff File

master ce7b57a0

2021-02-03 21:08:10

Greg V


Committer: wwmayer Details Diff
Sketcher: [skip ci] fix computing of hotspot of sketcher icons on Wayland

Restrict the hotspot multiplication on unix platforms to X11 (xcb platform)
mod - src/Mod/Sketcher/Gui/DrawSketchHandler.cpp Diff File
mod - src/Mod/Sketcher/Gui/PreCompiled.h Diff File

master 22214599

2021-02-03 20:56:43

wmayer

Details Diff
Gui: [skip ci] restore tab order in selection settings page
mod - src/Gui/DlgSettingsSelection.ui Diff File

master f3692604

2021-02-03 18:00:29

sliptonic

Details Diff
fix lgtm error
mod - src/Mod/Path/PathScripts/PathToolBitLibraryCmd.py Diff File

master af721d6f

2021-02-03 18:00:07

sliptonic

Details Diff
fix typos
mod - src/Mod/Path/PathScripts/PathDressupTag.py Diff File

master 27a6dedf

2021-02-03 17:28:14

Benjamin Alterauge


Committer: wwmayer Details Diff
Temporarily qt5 fixes for Apple Silicon need to disable the qtwebengine. That has to be considered in MacAppBundle.
mod - src/MacAppBundle/CMakeLists.txt Diff File

master d73ccbdb

2021-02-03 17:06:55

wmayer

Details Diff
Gui: add preferences tab for selection
mod - src/Gui/CMakeLists.txt Diff File
add - src/Gui/DlgSettingsSelection.cpp Diff File
add - src/Gui/DlgSettingsSelection.h Diff File
add - src/Gui/DlgSettingsSelection.ui Diff File
mod - src/Gui/resource.cpp Diff File

master ccbc13ee

2021-02-03 16:25:48

luz paz


Committer: wwmayer Details Diff
Draft: fix LGTM 'Testing for None should use the 'is' operator' alerrts

https://lgtm.com/projects/g/FreeCAD/FreeCAD/alerts/?mode=tree&ruleFocus=7900090
mod - src/Mod/Draft/draftfunctions/draftify.py Diff File
mod - src/Mod/Draft/draftgeoutils/geometry.py Diff File
mod - src/Mod/Draft/draftgeoutils/offsets.py Diff File
mod - src/Mod/Draft/draftgeoutils/wires.py Diff File
mod - src/Mod/Draft/draftmake/make_line.py Diff File
mod - src/Mod/Draft/draftobjects/patharray.py Diff File

master d064cdc2

2021-02-03 15:27:17

luz paz

Details Diff
Arch: Fix LGTM warning of missing param for translate() in ArchPanel.py

Even though this is ignored per the docs[1], LGTM complains[2] about it. This commit adds the superfluous param. Note: there is precedent in ArchReference.py[3] and ArchWall.py[4].

[1]https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/Draft/draftutils/translate.py#L73-L78
[2] https://lgtm.com/projects/g/FreeCAD/FreeCAD/snapshot/17db14c9700ae65d042d3548ef07f9518a115ba4/files/src/Mod/Arch/ArchPanel.py#L32
[3] https://github.com/FreeCAD/FreeCAD/blob/45dd1a7f608f822aaab4dc52d2308edb977a3f5a/src/Mod/Arch/ArchReference.py#L39
[4] https://github.com/FreeCAD/FreeCAD/blob/45dd1a7f608f822aaab4dc52d2308edb977a3f5a/src/Mod/Arch/ArchWall.py#L42
mod - src/Mod/Arch/ArchPanel.py Diff File

master 3ebd7d11

2021-02-03 15:10:38

wmayer

Details Diff
Part: [skip ci] rename methods in TopoShape that override non-virtual functions of base class
mod - src/Mod/Part/App/TopoShape.cpp Diff File
mod - src/Mod/Part/App/TopoShape.h Diff File

master 6db77375

2021-02-03 14:30:39

j


Committer: abdullah Details Diff
Sketcher: Group tests in different directories Affected Issues
0004533
mod - src/Mod/Sketcher/CMakeLists.txt Diff File
add - src/Mod/Sketcher/SketcherTests/TestSketchFillet.py Diff File
add - src/Mod/Sketcher/SketcherTests/TestSketcherSolver.py Diff File
add - src/Mod/Sketcher/SketcherTests/__init__.py Diff File
mod - src/Mod/Sketcher/TestSketcherApp.py Diff File

master 7b9d9fdc

2021-02-03 14:25:01

j


Committer: abdullah Details Diff
Sketcher: new fillet UI command Affected Issues
0004533
mod - src/Mod/Sketcher/Gui/CommandCreateGeo.cpp Diff File
mod - src/Mod/Sketcher/Gui/ViewProviderSketch.cpp Diff File
mod - src/Mod/Sketcher/Gui/Workbench.cpp Diff File

master 9fc31dfa

2021-02-03 14:15:46

j


Committer: abdullah Details Diff
Sketcher: new Fillet - icon Affected Issues
0004533
mod - src/Mod/Sketcher/Gui/Resources/Sketcher.qrc Diff File
add - src/Mod/Sketcher/Gui/Resources/icons/geometry/Sketcher_CreatePointFillet.svg Diff File

master 46feeb11

2021-02-03 14:14:14

j


Committer: abdullah Details Diff
Sketch: new fillet Python support Affected Issues
0004533
mod - src/Mod/Sketcher/App/SketchObjectPyImp.cpp Diff File

master f6f43b6f

2021-02-03 14:12:40

j


Committer: abdullah Details Diff
Sketcher: Constraint documentation Affected Issues
0004533
mod - src/Mod/Sketcher/App/Constraint.h Diff File

master 86992f80

2021-02-03 14:11:02

j


Committer: abdullah Details Diff
Sketcher: Preserve corner and constraints for sketch fillets

Currently the sketch fillet tool deletes any constraints associated with
the two lines to be filleted. By leaving a vertex at the intersection,
we can instead preserve most constraints in reasonable ways.

Sketch fillet horizontal and vertical point-to-point constraint support
Also better future compatibility for point constraints, and some minor tweaks.
Affected Issues
0004533
mod - src/Mod/Sketcher/App/SketchObject.cpp Diff File
mod - src/Mod/Sketcher/App/SketchObject.h Diff File
 First  Prev  1 2 3 ... 33 34 35 36 37 38 39 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 649 650 651  Next  Last